Happy New Year of the Rooster!
The Spring Festival is underway celebrating the Chinese New Year and another year of the Rooster, cf. e.g. The Telegraph newspaper article covering all these aspects:
Meanwhile, we continue our usual ongoing celebration of exciting Revit API news items:
cs script loaderTextNote alignmentcs Script LoaderEhsan Iran-Nejad announces happy news on pyRevit, which provides support for IronPython scripts and an add-in tab in Revit.
The idea #143 – add support for C# assemblies is already implemented:
Idea: I would like to propose adding support for loading C# assemblies.
To elaborate:
Instead of executing a Python script, a button would dynamically load and execute an IExternalCommand from a C# assembly, a bit like the Revit SDK Add-in Manager.
Answer: I'm glad you mentioned this.
pyRevit currently supports C# scripts.
It compiles them at runtime and creates executable commands for IExternalCommand.
It also supports IExternalCommandAvailability.
Just as with the Add-In Manager, you can modify the C# code on the fly and reload pyRevit without closing the current Revit session.
Look at the button bundle listed below.
It only has a .cs file instead of a .py file.
This is a work-in-progress feature and thus not announced yet, but technically you can create C# bundles right now already.
The unfinished component of this feature is that I need to make the compiler smart about the assemblies it needs to reference for the C# script to work.
Currently, it references these assemblies by default, which is more than enough for most commands:
Here is the bundle folder to Test C# Script.pushbutton.
Here is yet another new solution
for using FilteredElementCollector to select model elements, i.e., visible 3D elements,
from the Revit API discussion forum thread
on selecting all physical items in model:
Question: I am trying to select all the model element instances in my model. i.e. anything that is a physical object, so I can change the value of a certain property on them. The property value will be different depending on where the instance is in the model. I have the below method but it is not picking up host families or the likes of ducts:
IList<Element> GetFamilyInstanceModelElements( Document doc ) { ElementClassFilter familyInstanceFilter = new ElementClassFilter( typeof( FamilyInstance ) ); FilteredElementCollector familyInstanceCollector = new FilteredElementCollector( doc ); IList<Element> elementsCollection = familyInstanceCollector.WherePasses( familyInstanceFilter ).ToElements(); IList<Element> modelElements = new List<Element>(); foreach( Element e in elementsCollection ) { if( ( null != e.Category ) && ( null != e.LevelId ) && ( null != e.get_Geometry( new Options() ) ) ) { modelElements.Add( e ); } } return modelElements; }
Answer 1: Your filter looks OK to me.
Please note that the conversion from the familyInstanceCollector to the generic list elementsCollection is unnecessary and inefficient, as explained numerous times in the past, e.g.
in the discussions
of ToElementIds performance
and use of LINQ with filtered element collectors.
Please also look at The Building Coder topic group
on using FilteredElementCollector to select model elements, i.e., visible 3D elements.
Answer 2: When you use a FamilyInstance filter, you only find user created families, i.e., RFA-based, and not the built-in system families.
Try:
public static class JtElementExtensionMethods { public static bool IsPhysicalElement( this Element e ) { if( e.Category == null ) return false; if( e.ViewSpecific ) return false; // exclude specific unwanted categories if( ( (BuiltInCategory) e.Category.Id.IntegerValue ) == BuiltInCategory.OST_HVAC_Zones ) return false; return e.Category.CategoryType == CategoryType.Model && e.Category.CanAddSubcategory; } } IEnumerable<Element> SelectAllPhysicalElements( Document doc ) { return new FilteredElementCollector( doc ) .WhereElementIsNotElementType() .Where( e => e.IsPhysicalElement() ); }
Answer 3: I'd probably use .WhereElementIsViewIndependent in there somewhere also.
Faster than some of the iteration/LINQ methods, cf. the comparison of quick, slow and LINQ element filtering.
Extracting element data from Revit to .NET and checking it there, e.g., with LINQ, costs at least twice as much time as leaving it on the Revit side and applying some kind of filter instead.
Therefore, whenever possible, it pays off hugely to analyse all the element properties and how they are reflected in parameter values.
The parameter values can be filtered using a filtered element collector parameter filter.
50% speed improvement over using LINQ post-processing guaranteed!
I added these new model element selection methods
to The Building Coder samples,
implementing SelectAllPhysicalElements in release 2017.0.132.1 and
adding the WhereElementIsViewIndependent check in release 2017.0.132.2.
Answer 4: I agree that you should use the WhereElementIsViewIndependent filter instead of checking Element.ViewSpecific.
The rest of the checks in the IsPhysicalElement predicate check properties of the Element.Category and I think those can't be filtered in a fast filter.
An alternative approach would be to define your own set of categories (maybe 20-30).
All elements in the 'physical' model would belong to that set, if you have defined it correctly.
Then you can use an ElementMulticategoryFilter combined with WhereElementIsNotElementType and WhereElementIsViewIndependent.
Many thanks to Frank 'Fair59' and Matt Taylor for the good suggestions!
This is a continuation of
the TextNote rotation issue discussed
last week, raised in
the Revit API discussion forum thread
on TextNote vertical alignment on line in Revit 2016:
Question:
I've managed to position text notes rotated along lines.
Now I need to set the vertical alignment of the text, so the text is centred on the lines like this:
In Revit 2015 I used the TextAlignFlags.TEF_ALIGN_MIDDLE, but it seems to be removed in 2016.
Is there method to align the vertical position of the text, or do I have to calculate a new position of the text according to its height and scale?
Answer 1:
<rant>
The (frustrating) omission of the vertical text alignment mimics the user interface. Gah.
Labels in tag families do have a modifiable vertical alignment, but these can't often be rotated. Gah.
So you're in the frustrating position of working out the text position manually. Gah.
Enough to drive you gaga? ;-)
It seems to me that the Revit developers have a mandate to stay away from simple drawing objects such as lines and text, and lean towards smarter objects like line-based families and tags. I commend that (if that is what is happening), but it also drives me nuts at times.
</rant>
I was in the situation you are in. I ended up creating a line-based family with a nested annotation symbol in it. I needed to programmatically manage some of the family placement/scale etc. The bonus of this was that it allowed the user to modify the lines once placed (without needing an iUpdater to do so).
If you just want text, you may be able to get away with getting the centre of the text bounding box and moving it to the midpoint of your line. You'll probably need two transactions to do that.
Answer 2:
Very sorry about the frustrating situation.
Have you raised a wish list for this in the Revit Idea Station?
You might get a lot of votes for that one.
Now to go on with the topic at hand.
It has been discussed here in the past in the thread on text alignments.
Apparently, as far as the development team is concerned, the vertical alignment possibility should never have been implemented.
Arnošt Löbel explained that in detail in a discussion thread on creating a text note with the 2016 API changes.
Please also refer to the comments by David Rushforth on What's New in the Revit 2016 API.
Can you check these out and see whether they help?
I do hope we can resolve this somehow, because this request has cropped up a few times now.
Is it possible to achieve what you show in your second figure using a custom line type?
Here are two solutions that come up immediately in an Internet search:
Response:
For now, I prefer to use simple text notes, as these texts are only used for sheet views.
Also, some users might need to delete or move a text element, to give way for more important geometry.
Thanks for the idea about getting values from the text bounding box. That's probably the best way of calculating the offset distance.
I'm not using detail lines. The lines shown are actually pipe system, shown with single line representation.
A line based family is too constricted for our needs.
Answer 3:
The discussions you point to don't help me understand why vertical alignment isn't included in either the UI or the API.
If Revit could do everything as a user would want it, text wouldn't exist. It would all be internal/external databases, tags, references etc. That is not the case.
So, a user (or programmer) must be able to add text that can be positioned in a manner that editing the text element's content doesn't make it wrap in an undesirable way.
There are 21 ideas in the Idea Station using the search 'text alignment'.
While the 'no vertical alignment' stance may make sense from an Autodesk point of view, it makes zero sense from a user viewpoint. Any user would have told the development team that. The 21 ideas voice this also.
I've been using the Revit API since Revit 2011.
Originally, I was like, I'll use TextNoteCreationData to batch create text, because that'll be faster than creating them individually (after some testing).
That got deprecated in Revit 2013 and obsoleted in Revit 2014.
In Revit 2013, the NewTextNote creation method was heralded as being as efficient as the batch method.
Then that was deprecated in Revit 2016, and obsoleted in Revit 2017.
In Revit 2016, enter the 'new' static Create method. A devolved version, in preparation for the Revit 2017 text element overhaul. Adjustment required after initial creation transaction.
The roadmap isn't clear.
It's not annoying, really, just disappointing, time sapping, and ambiguous. The 2017 'improvements' weren't enough!
Sorry, this message is longer than I wanted! And sorry it's another rant...
Answer 4:
Note that this is not supported functionality...
But it so happens that you can still set the vertical alignment through the TEXT_ALIGN_VERT built-in parameter.
It needs to be set to TextAlignFlags.TEF_ALIGN_TOP, TextAlignFlags.TEF_ALIGN_MIDDLE or TextAlignFlags.TEF_ALIGN_BOTTOM, like in this C# snippet:
using( Transaction t = new Transaction( doc ) ) { t.Start( "AlignTextNote" ); Parameter p = textNote.get_Parameter( BuiltInParameter.TEXT_ALIGN_VERT ); p.Set( (Int32) TextAlignFlags.TEF_ALIGN_MIDDLE ); t.Commit(); }
Hope that helps.
Meanwhile we will have a look to see what is involved to get this formally exposed.
Response:
Perfect! Just what I needed.